Skip to content

[HMR] Avoid clearing out factory on DEV mode #7568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinbigio wants to merge 1 commit into from
Closed

[HMR] Avoid clearing out factory on DEV mode #7568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packager/react-packager/src/Resolver/polyfills/require.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,11 @@ function loadModuleImplementation(moduleId, module) {
// keep args in sync with with defineModuleCode in
// packager/react-packager/src/Resolver/index.js
factory(global, require, moduleObject, exports);
module.factory = undefined;

// avoid removing factory in DEV mode as it breaks HMR
if (!__DEV__) {
module.factory = undefined;
}

if (__DEV__) {
Systrace.endEvent();
Expand Down