[DevTools] Ignore duplicate commit tree adds - #36474
Open
yudin-s wants to merge 2 commits into
Open
Conversation
eps1lon
requested changes
May 27, 2026
eps1lon
left a comment
eps1lon
left a comment
Collaborator
There was a problem hiding this comment.
The test should reproduce the duplicate tree add instead of manually forcing one. The duplicate add would be the bug that needs fixing instead of just ignoring it.
eps1lon
reviewed
Jun 22, 2026
|
|
||
| // Replay a duplicated payload using the same snapshot and operations shape | ||
| // that ProfilerStore records from the renderer. | ||
| dataForRoot.operations.push(dataForRoot.operations[0].slice()); |
Collaborator
There was a problem hiding this comment.
Is that part of the public API? This looks like it's using internals triggering the bug instead of legit usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #36124.
Fixes #36006.
The Profiler commit tree can receive duplicate add operations for a fiber that is already present in the reconstructed tree. Instead of throwing while rendering Profiler charts, skip the duplicate add payload and continue applying later operations for that commit.
How did you test this change?