DevTools: Fix nested HOC name extraction in extractHOCNames - #37215
Merged
Conversation
Contributor
Author
|
cc @hoxyq |
hoxyq
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There was a bug in the helper that unwraps component names like Forget(Memo(Button)) into a base component name plus its HOC wrappers. The regex was using the g flag, which means exec() remembers its position via lastIndex. Since each iteration replaces the current string with the shorter unwrapped inner string, lastIndex ends up pointing past the end of the new string. The next exec() returns null, so the loop stops after unwrapping only the outermost HOC.
component named Forget(Memo(ForgetMemoCounter))
before fixes ✨Memo(ForgetMemoCounter)
after fixes ✨🧠ForgetMemoCounter
component named Forget(ForwardRef(ForgetForwardRefCounter))
before fixes ✨ForwardRef(ForgetForwardRefCounter)
after fixes ✨ForgetForwardRefCounter
How did you test this change?
Tested the change locally in
devtooland added tests for the sameBefore
After
Not sure if we need a new fixture can add one if required