Add missing reference to CXX to yoga_defs.bzl - #1132
Conversation
|
Hi @shmax! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
#1166 removed Buck from the repo in general, since it hasn't been exercised. I am planning to follow up with a change that allows running C++ UTs via CMake. Though ideally we would expose tests for the JNI bindings to OSS, like we were some time ago. |
Fix for #1131
This issue seems to have been introduced in 477fedd
I don't know if this is a complete fix, as I'm still not having any luck getting the tests to run on Windows ("File not found: cl
"), but I thought I may as well get the conversation started.