Fix wrong color for disabled input fields on iOS #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rwachtler
commented
Oct 22, 2019
rwachtler
commented
- Added -webkit-text-fill-color to createDisabledTextStyles
- Fixes Wrong text color in disabled input fields on iOS #56
- Added -webkit-text-fill-color to createDisabledTextStyles
rwachtler
commented
Oct 22, 2019
| color: ${({ theme }) => theme.textDisabled}; | ||
| text-shadow: 1px 1px ${({ theme }) => theme.textDisabledShadow}; | ||
| /* filter: grayscale(100%); */ | ||
| -webkit-text-fill-color: ${({ theme }) => theme.inputTextDisabled}; |
Contributor
Author
There was a problem hiding this comment.
In my opinion this is a better location to fix this issue, instead of writing it twice into separate components. Other components using the createDisabledTextStyles() function shouldn't be affected by this change.
rwachtler
commented
Oct 22, 2019
Member
|
@rwachtler I will review it before the weekend. thanks and welcome to React95 🔥 |
…x/disabled-text-color-ios-input
Member
|
🎉 This PR is included in version 3.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.