Skip to content

Fix wrong color for disabled input fields on iOS #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Fix wrong color for disabled input fields on iOS #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1ad111
Fix wrong color for disabled input fields on iOS
Oct 22, 2019
0757ce8
Merge branch 'master' of https://github.com/arturbien/React95 into fi…
Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export const createDisabledTextStyles = () => css`
color: ${({ theme }) => theme.textDisabled};
text-shadow: 1px 1px ${({ theme }) => theme.textDisabledShadow};
/* filter: grayscale(100%); */
-webkit-text-fill-color: ${({ theme }) => theme.inputTextDisabled};
Copy link
Contributor Author

@rwachtler rwachtler Oct 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion this is a better location to fix this issue, instead of writing it twice into separate components. Other components using the createDisabledTextStyles() function shouldn't be affected by this change.

`;
export const createBoxStyles = () => css`
box-sizing: border-box;
Expand Down