This repository was archived by the owner on Sep 22, 2022. It is now read-only.
fix: add Spanish translations#6
Merged
willopez merged 1 commit intoreactioncommerce:trunkfrom Jul 23, 2020
Merged
Conversation
Signed-off-by: Matias Zuniga <matias.nicolas.zc@gmail.com>
Member
|
Looks great @Manizuca There is one missing translation for the place holder seen below: |
Contributor
Author
|
That one is hard-coded in reaction-admin/imports/plugins/core/tags/client/components/TagForm.js#L430. It should probably use a new "admin.tags.form.namePlaceholder" translation? |
Member
|
@Manizuca Yes, it should use a translation key and not be hard-coded. |
Collaborator
|
🎉 This PR is included in version 1.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matias Zuniga matias.nicolas.zc@gmail.com
Impact: minor
Type: bugfix
Issue
Translations on the "Tags" section of the admin panel are missing.
Solution
Add Spanish translations to the tags plugin.
Testing
Link this PR into the Reaction API
Start Reaction
Go to the admin panel with a browser that has Spanish as primary language
Go to the "Tags" section, look at the spanish translations