Skip to content

Conversation

@dancastellon
Copy link
Contributor

Resolves #324
Impact: minor
Type: bugfix

Issue

In the grid, the image fit prop was not recalculating when the CatalogGridItem component was updated with a different product

Solution

Simply called image fit calculation logic on componentDidUpdate fixed the issue.

Breaking changes

None

Testing

  1. Load up the starterkit with the catalog sample data
  2. Visit homepage, click next, click previous
  3. Confirm images all still perfectly fit the square. Previously after clicking previous, portrait images would have white bars on the left/ & right.

Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit 7d76785 into master Sep 21, 2018
@mikemurray mikemurray deleted the fix-324-dancastellon-image-size-issue branch September 21, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants