Skip to content

Conversation

@Akarshit
Copy link
Contributor

@Akarshit Akarshit commented Apr 9, 2021

Impact: major
Type: feature

This PR adds supports to handle authentication via account-js and keeps the storefront up-to-date with the latest authentication plugin.

Breaking changes

This version uses account-js to handle authentication. The older accounts created with Hydra/Identity should work. But things like reset password emails that were sent before the update would no longer work.

Testing

  1. Create some accounts with the old hydra/identity setup.
  2. Pull this branch, link it as a plugin.
  3. Try to access old accounts, those accounts should be accessible.
  4. Test signup flow -> click create account, enter email/password, hit Sign Up, this should create an account.
  5. Test login flow -> enter email password, the user should be logged in.
  6. Test update password flow -> after login, reset password, logout, login with new password.
  7. Test forgot password flow -> setup email (or atleast console.log them), try to login, hit Forgot Password, enter email address, get the reset link, click on that, enter new password, try to login with that password

@Akarshit Akarshit force-pushed the akarshit-feat-account-js-auth branch from 5a9aec3 to e22b709 Compare April 13, 2021 06:47
@Akarshit Akarshit force-pushed the akarshit-feat-account-js-auth branch 4 times, most recently from 2b4845d to cdf3195 Compare April 15, 2021 05:06
@Akarshit Akarshit force-pushed the akarshit-feat-account-js-auth branch from cdf3195 to 17b8e68 Compare April 22, 2021 15:46
@Akarshit Akarshit changed the title [WIP] feat: use account-js for authentication feat: use account-js for authentication Apr 22, 2021
@Akarshit Akarshit force-pushed the akarshit-feat-account-js-auth branch from 17b8e68 to af8faf3 Compare April 22, 2021 19:13
@Akarshit Akarshit force-pushed the akarshit-feat-account-js-auth branch 3 times, most recently from d119bc3 to f6c9d44 Compare April 26, 2021 17:54
@Akarshit
Copy link
Contributor Author

Updated the PR to pass the builds.

BREAKING CHANGE: the authorization methods have been switched to account-js
Signed-off-by: Akarshit Wal <akarshitwal@gmail.com>
@Akarshit Akarshit force-pushed the akarshit-feat-account-js-auth branch from f6c9d44 to ada5a3a Compare May 6, 2021 15:22
@Akarshit
Copy link
Contributor Author

Akarshit commented May 6, 2021

Only updated the commit message in the last push.

@Akarshit Akarshit merged commit 3bcc8b4 into trunk May 6, 2021
@rc-publisher
Copy link
Collaborator

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rc-publisher rc-publisher added the released Applied automatically by semantic-release label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Applied automatically by semantic-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants