Skip to content

Conversation

@reactive-firewall
Copy link
Owner

…tions that are not triggered

- added new functions for file encryption tasks as part of #20
- added relevent tests for new file encryption functions
- refactored extension utilities
- refactored some tests that caused regression bugs in local testing
- refactored error breakpoints for use while debugging
- fixed failing tests for #20
- added some function for config files as part of #28
…tions that are not triggered

- added new functions for file encryption tasks as part of #20
- added relevent tests for new file encryption functions
- refactored extension utilities
- refactored some tests that caused regression bugs in local testing
- refactored error breakpoints for use while debugging
- fixed failing tests for #20
 - added new functions
 - added tests for new functions
return theResult


@remediation.error_handling

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C901 'writeMainConfigFile' is too complex (12)

raise unittest.SkipTest("BETA. Experemental feature not ready yet.")
assert theResult

def test_case_clearify_read_write(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C901 'CryptoTestSuite.test_case_clearify_read_write' is too complex (12)

raise unittest.SkipTest("BETA. Experemental feature not ready yet.")
assert theResult

def test_case_clearify_read_write(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'CryptoTestSuite.test_case_clearify_read_write' is too complex (12)

return theResult


@remediation.error_handling

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'writeMainConfigFile' is too complex (12)

@coveralls
Copy link

coveralls commented Jul 31, 2017

Coverage Status

Coverage decreased (-0.02%) to 84.093% when pulling 89b0d63 on master into ddb15d2 on stable.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 84.093% when pulling 89b0d63 on master into ddb15d2 on stable.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 84.093% when pulling 89b0d63 on master into ddb15d2 on stable.

@codecov-io
Copy link

codecov-io commented Jul 31, 2017

Codecov Report

Merging #39 into stable will increase coverage by 0.83%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable      #39      +/-   ##
==========================================
+ Coverage   83.54%   84.37%   +0.83%     
==========================================
  Files          26       26              
  Lines        2109     2215     +106     
==========================================
+ Hits         1762     1869     +107     
+ Misses        347      346       -1
Impacted Files Coverage Δ
piaplib/pku/interfaces.py 88.31% <100%> (ø) ⬆️
piaplib/pku/remediation.py 100% <100%> (ø) ⬆️
piaplib/lint/users_check_status.py 86.31% <100%> (+3.42%) ⬆️
piaplib/__init__.py 100% <100%> (ø) ⬆️
piaplib/lint/iface_check_status.py 76.36% <71.42%> (+1.51%) ⬆️
piaplib/lint/clients_check_status.py 47.17% <77.77%> (+0.21%) ⬆️
piaplib/lint/html_generator.py 94.44% <80%> (+2.55%) ⬆️
piaplib/pku/config.py 86.84% <81.96%> (-4.59%) ⬇️
piaplib/keyring/clearify.py 94.69% <92.59%> (-0.55%) ⬇️
piaplib/pku/utils.py 97.58% <95.45%> (-0.26%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb15d2...aae3f4d. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 2, 2017

Coverage Status

Coverage increased (+0.2%) to 84.294% when pulling 9e0b3e4 on master into ddb15d2 on stable.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 84.294% when pulling 9e0b3e4 on master into ddb15d2 on stable.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 84.294% when pulling 9e0b3e4 on master into ddb15d2 on stable.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 84.294% when pulling 9e0b3e4 on master into ddb15d2 on stable.

@coveralls
Copy link

coveralls commented Aug 2, 2017

Coverage Status

Coverage increased (+0.3%) to 84.437% when pulling 8d24a56 on master into ddb15d2 on stable.

@coveralls
Copy link

coveralls commented Aug 2, 2017

Coverage Status

Coverage increased (+0.4%) to 84.47% when pulling aae3f4d on master into ddb15d2 on stable.

@reactive-firewall reactive-firewall merged commit aae3f4d into stable Aug 2, 2017
reactive-firewall added a commit that referenced this pull request Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants