chore: React Native 0.85, @react-native/jest-preset, React 19.2.3 alignment#3890
chore: React Native 0.85, @react-native/jest-preset, React 19.2.3 alignment#3890
Conversation
Bump react-native to 0.85.0, babel-plugin-syntax-hermes-parser to ^0.35.0, and add @react-native/jest-preset for the ReactNative Jest project (resolver, setup, env, asset transformer, react-native subpath mapper). Pin react, react-dom, and react-test-renderer to 19.2.3 to match react-native-renderer. Fix subscriptions.native test import to use @data-client/test. Co-authored-by: Nathaniel Tucker <me@ntucker.me>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
|
Size Change: 0 B Total Size: 80.7 kB ℹ️ View Unchanged
|
Co-authored-by: Nathaniel Tucker <me@ntucker.me>
There was a problem hiding this comment.
Benchmark React
Details
| Benchmark suite | Current: abd602b | Previous: 7df6a49 | Ratio |
|---|---|---|---|
data-client: getlist-100 |
131.58 ops/s (± 5.7%) |
141.85 ops/s (± 5.6%) |
1.08 |
data-client: getlist-500 |
39.84 ops/s (± 5.6%) |
39.45 ops/s (± 7.1%) |
0.99 |
data-client: update-entity |
322.58 ops/s (± 9.1%) |
416.67 ops/s (± 9.3%) |
1.29 |
data-client: update-user |
327.96 ops/s (± 8.5%) |
370.37 ops/s (± 9.7%) |
1.13 |
data-client: getlist-500-sorted |
42.2 ops/s (± 5.7%) |
43.2 ops/s (± 6.2%) |
1.02 |
data-client: update-entity-sorted |
274.02 ops/s (± 8.8%) |
333.33 ops/s (± 8.6%) |
1.22 |
data-client: update-entity-multi-view |
312.5 ops/s (± 5.8%) |
370.37 ops/s (± 9.7%) |
1.19 |
data-client: list-detail-switch-10 |
6.76 ops/s (± 4.2%) |
7.86 ops/s (± 10.2%) |
1.16 |
data-client: update-user-10000 |
80.65 ops/s (± 4.2%) |
80.01 ops/s (± 14.7%) |
0.99 |
data-client: invalidate-and-resolve |
33.28 ops/s (± 5.6%) |
34.84 ops/s (± 4.7%) |
1.05 |
data-client: unshift-item |
210.55 ops/s (± 4.1%) |
232.56 ops/s (± 3.2%) |
1.10 |
data-client: delete-item |
274.02 ops/s (± 6.2%) |
294.12 ops/s (± 6.7%) |
1.07 |
data-client: move-item |
178.63 ops/s (± 5.7%) |
196.08 ops/s (± 6.0%) |
1.10 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3890 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 153 153
Lines 2916 2916
Branches 566 566
=======================================
Hits 2861 2861
Misses 11 11
Partials 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…e.json The lockfiles for github-app, nextjs, and todo-app had react and react-dom at 19.2.5 while their package.json files pinned 19.2.3. This mismatch would cause npm ci to fail. Regenerated lockfiles to resolve correctly. Co-authored-by: Nathaniel Tucker <me@ntucker.me>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7635617. Configure here.
The capture group ($|/.*) already includes the leading slash for sub-path imports like react-native/Libraries/Text, so the extra / in the replacement template produced double slashes (e.g. <rnDir>//Libraries/Text). Removing the redundant / fixes both bare react-native (empty capture) and sub-path imports. Co-authored-by: Nathaniel Tucker <me@ntucker.me>
…ement Co-authored-by: Nathaniel Tucker <me@ntucker.me>

Summary
jest/entry points: resolver, setup, test environment, and asset file transformer, while keeping @anansi/jest-preset as the overall preset (we do not setpreset: '@react-native/jest-preset').^react-native($|/.*)moduleNameMapper, with replacementdirname(react-native/package.json) + $1so subpath imports do not get a double slash ($1already includes the leading/when present).Verification
yarn ci:build-test-libyarn test:ciNote
No changeset: internal tooling / CI dependency alignment, not a shipping API change.