Skip to content

InsertAllObjects self recursion#258

Merged
anaisbetts merged 2 commits into
masterfrom
unknown repository
Dec 17, 2015
Merged

InsertAllObjects self recursion#258
anaisbetts merged 2 commits into
masterfrom
unknown repository

Conversation

@ncruces

@ncruces ncruces commented Dec 16, 2015

Copy link
Copy Markdown
Contributor

Should fix #219.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't rename a public method in a patch

@ncruces

ncruces commented Dec 16, 2015

Copy link
Copy Markdown
Contributor Author

Sorry about that, it was a mistake.

JsonSerializationMixin.InsertAllObjects should remain as is, but it should delegate to BulkOperationsMixin.InsertObjects iff This implements IObjectBlobCache.

Going down this rabbit hole I also noted that BulkOperationsMixin.Insert and BulkOperationsMixin.InsertObjects don't pass down the absoluteExpiration.

@ncruces ncruces changed the title Rename InsertAllObjects InsertAllObjects self recursion Dec 16, 2015
@anaisbetts

Copy link
Copy Markdown
Member

👍

anaisbetts added a commit that referenced this pull request Dec 17, 2015
InsertAllObjects self recursion
@anaisbetts anaisbetts merged commit cd72b70 into reactiveui:master Dec 17, 2015
@ghuntley ghuntley modified the milestone: 5.0.0 Nov 4, 2016
@ghuntley ghuntley added the Bug label Nov 4, 2016
@lock lock Bot locked and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InsertAllObjects on android crashes v4.1.1

3 participants