Skip to content

build: update package dependencies#4417

Merged
glennawatson merged 6 commits into
mainfrom
glennawatson/update-packages
Jul 25, 2026
Merged

build: update package dependencies#4417
glennawatson merged 6 commits into
mainfrom
glennawatson/update-packages

Conversation

@glennawatson

@glennawatson glennawatson commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Build and dependency maintenance, together with the code changes required by the updated analyzers.

What is the new behavior?

NuGet dependencies use the latest compatible versions for each supported target framework. The conditions are derived from the repository's complete MSBuild target matrix, including .NET Framework, plain .NET, Windows, Android, and the Apple targets.

.NET 10 continues to reference Microsoft.Maui.Controls.Compatibility 10.0.90. .NET 11 uses MAUI preview 6 without that reference because the compatibility package is no longer built or shipped for .NET 11.

Diagnostics introduced by the analyzer updates are fixed in code without adding suppressions. Tests that became exact duplicates under the new analyzer are either corrected to exercise their intended case or removed when they exercised the same call path.

What is the current behavior?

Dependencies use older stable and preview versions. MAUI compatibility is referenced without accounting for its removal from .NET 11, and the newer analyzer diagnostics are not addressed.

What might this PR break?

None expected. Existing target frameworks remain supported, and package references are conditioned per target framework.

Checklist

  • I have read the Contribute guide
  • Tests have been added or updated (for bug fixes / features)
  • Docs have been added or updated (for bug fixes / features)
  • Changes target the main branch
  • PR title follows Conventional Commits

Additional information

  • Full Release solution build: 0 warnings, 0 errors.
  • Full solution tests: 33,404 passed, 0 failed, 0 skipped.
  • MAUI strategy reference: dotnet/maui#35870.

- Upgrade dependencies for each supported target framework.
- Fix diagnostics introduced by the updated analyzers without suppressions.
- Remove the .NET 11 MAUI compatibility dependency that is no longer shipped.
@glennawatson
glennawatson marked this pull request as ready for review July 25, 2026 13:20
- Apply the required layout to Apple-only source files.
- Make disposable ownership explicit without disposing borrowed instances.
- Reuse the macOS persistence callback for identical lifecycle behavior.
- Force LF checkouts for every tracked text file on all platforms.
- Remove the remaining solution and Windows script CRLF overrides.
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
8.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.07968% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.15%. Comparing base (fb0c249) to head (672f37e).

Files with missing lines Patch % Lines
...activeUI.Shared/ReactiveCommand/ReactiveCommand.cs 68.08% 15 Missing ⚠️
src/ReactiveUI.Shared/Builder/RxAppBuilder.cs 0.00% 7 Missing ⚠️
...eUI.Shared/Scheduler/WaitForDispatcherScheduler.cs 0.00% 7 Missing ⚠️
.../ObservableForProperty/OAPHCreationHelperMixins.cs 63.63% 0 Missing and 4 partials ⚠️
src/ReactiveUI.Wpf.Shared/Common/RoutedViewHost.cs 20.00% 3 Missing and 1 partial ⚠️
.../ReactiveUI.Wpf.Shared/Common/ViewModelViewHost.cs 0.00% 3 Missing ⚠️
....Shared/Mixins/AutoPersistHelperMixins.Metadata.cs 33.33% 2 Missing ⚠️
...ReactiveUI.Shared/ReactiveObject/ReactiveObject.cs 83.33% 1 Missing and 1 partial ⚠️
...veUI.Core/Bindings/BindingTypeConverterDispatch.cs 50.00% 0 Missing and 1 partial ⚠️
...c/ReactiveUI.Core/Expression/ExpressionRewriter.cs 50.00% 0 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4417      +/-   ##
==========================================
- Coverage   93.18%   93.15%   -0.04%     
==========================================
  Files         345      345              
  Lines       15006    14965      -41     
  Branches     1568     1568              
==========================================
- Hits        13984    13941      -43     
- Misses        750      752       +2     
  Partials      272      272              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@glennawatson
glennawatson merged commit 180a40b into main Jul 25, 2026
10 of 13 checks passed
@glennawatson
glennawatson deleted the glennawatson/update-packages branch July 25, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants