Warning page for invalid Hook calls #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add warning for invalid hook call * Fix versions * Split code examples * unnecessary comma * tweaks * Update content/warnings/invalid-hook-call-warning.md Co-Authored-By: gaearon <dan.abramov@gmail.com> * nit
Member
Author
|
This issue was autogenerated by the bot. @smikitky, do you want to merge as-is and translate it later or would you like someone to translate it now? |
smikitky
approved these changes
Feb 2, 2019
Member
|
@tesseralis I'd rather merge it as-is and assign someone to translate it later. CI is complaining about this line (bracket mismatch; false positive), but we can ignore it |
Member
Author
|
@smikitky could you handle that? I'm not familiar with the textlint rules. |
Member
|
@tesseralis Yes, as a repo admin, I can merge anyway. Can I merge this right away? |
Member
Author
|
@smikitky Will merging this cause all other PRs to fail from the same reason? |
Member
|
@tesseralis Ah, you're right, then I'll try to find a way to fix it before merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #33
Cherry picked from reactjs/react.dev@f149987