Skip to content

react-dom should probably be a peerDependency #219

@boucher

Description

@boucher

Summary:

React is being declared as a peerDependency, but react-dom is not (but both are dev dependencies).

Steps to reproduce:

  1. Visit https://tonicdev.com/npm/react-modal and try to run the example

Expected behavior:

The package should be required. It will fail because of the missing peer dependency. If you add a require("react-dom") before hand, it will work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions