[fixed] management of aria-hidden attribute #602
Merged
diasbruno merged 1 commit intoreactjs:masterfrom Feb 2, 2018
Merged
Conversation
…ment of the body open class
6f1639b to
abdd065
Compare
Collaborator
Author
|
That'd be great @diasbruno; this problem with |
diasbruno
approved these changes
Feb 2, 2018
Author
|
@diasbruno any update on when you're going to do the next release so we can pickup this change for Slack? |
Collaborator
|
Ok, I'll make a new release today. |
Collaborator
|
Released Also, since Slack team is contributing to react-modal, it would be great if someone on the team join in to help manage this project. Let me know if you or someone on your team would like to join. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #601.
Changes proposed:
Decouples the management of the
aria-hiddenattribute from the code managing the class representing the open stateAcceptance Checklist:
CONTRIBUTING.md.