Skip to content

[fixed] Can't close Modal B on examples#726

Merged
diasbruno merged 2 commits intoreactjs:masterfrom
FullMoon04:fix/examples
Feb 1, 2019
Merged

[fixed] Can't close Modal B on examples#726
diasbruno merged 2 commits intoreactjs:masterfrom
FullMoon04:fix/examples

Conversation

@FullMoon04
Copy link
Copy Markdown
Contributor

Fixes #725.

Changes proposed:

  • can close modal B with close button

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 86.56% when pulling 27b30ac on FullMoon04:fix/examples into d4a8a32 on reactjs:master.

@FullMoon04
Copy link
Copy Markdown
Contributor Author

I noticed now that I can close a modal with esc.
However, I think it would be better to have a button to close the modal B.

@rocifier
Copy link
Copy Markdown

rocifier commented Feb 1, 2019

I think this should be merged, it actually fixes the issue.

@diasbruno
Copy link
Copy Markdown
Collaborator

Oh, sorry for the delay on this one. I'll merge this.

Thanks @FullMoon04 and @rocifier.

@diasbruno diasbruno merged commit ec3f749 into reactjs:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't close modal B on examples

4 participants