Closed
Conversation
Fixes #[issue number]. Changes proposed: Updates copyright year to current year Upgrade Path (for changed or removed APIs): Acceptance Checklist: -[x] All commits have been squashed to one. -[x] The commit message follows the guidelines in CONTRIBUTING.md. -[x] Documentation (README.md) and examples have been updated as needed. -[x] If this is a code change, a spec testing the functionality has been added. -[x] If the commit message has [changed] or [removed], there is an upgrade path above.
|
IANAL. The Copyright year traditionally denotes the time that something was created, and only needs updating if there are significant changes that necessitate updating a policy or something. In this case, updating the year to 2019, I think, is incorrect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #[issue number].
Changes proposed:
Updates copyright year to current year
Upgrade Path (for changed or removed APIs):
Acceptance Checklist:
CONTRIBUTING.md.