Skip to content

Conversation

@callmenick
Copy link
Contributor

Changes proposed:

  • Added testId prop existence and usage to documentation

Upgrade Path (for changed or removed APIs):

Acceptance Checklist:

  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.135% when pulling d5a30f6 on callmenick:patch-1 into 8efaa37 on reactjs:master.

@diasbruno
Copy link
Collaborator

Thanks, @callmenick. Can you also check if we have a test for this, please?

@callmenick
Copy link
Contributor Author

No problem @diasbruno. I do indeed see that it's tested here:

https://github.com/reactjs/react-modal/blob/master/specs/Modal.spec.js#L434

@diasbruno diasbruno merged commit bd07d56 into reactjs:master Apr 30, 2020
@callmenick callmenick deleted the patch-1 branch May 5, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants