Skip to content

Confusing Variable Naming: "step" & "move" #4581

Description

@liang256

At line 1139, jumpTo() requires an argument named step.
However, on lines 1017, and 1106, it passes the variable, move, into jumpTo function, which is confusing.

I think it's better either change the naming of the argument of jumpTo() (:1139),
or switch the naming of currentValue and index of map() (:1017, :1106)

The below PR goes the second way since I think move is more like representing the "movement", on the other hand, step is understood as a "number" in most cases.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions