Fix: Collapsing Sidebar Sections - #3371
Conversation
|
Hi @1209simran! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Deploy preview for reactjs ready! Built without sensitive environment variables with commit b705b51 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
This doesn't look right. If sectionList.length === 0 then we wouldn't ever get here since we're inside sectionList.map(...). I think this was actually intentional (what's the point of collapsing the only section?) although I agree this design is a bit confusing. It would make sense to me to just remove the arrow if the length is 1.
There was a problem hiding this comment.
Yes @gaearon, this design looks confusing to me for the single section that's why I replace the length. I'll try to remove the arrow instead of replacing the length to 0.
There was a problem hiding this comment.
@gaearon, I've removed the arrow instead of changing the length. Please check the updated PR.
40b2ce4 to
b705b51
Compare
5 participants
When we click on the sidebar sections of Community, Blog or Tutorials Page, the button doesn't collapse.