Passing post content on the key passing example - #3456
Open
bcdasilv wants to merge 1 commit into
Open
Conversation
|
Deploy preview for reactjs ready! Built without sensitive environment variables with commit 2ec0389 |
codingsamurai-10
approved these changes
Dec 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the official documentation (https://reactjs.org/docs/lists-and-keys.html) there is this Blog Posts example.
In one section (https://reactjs.org/docs/lists-and-keys.html), there's one example of creating a Post component and passing the key, besides the id and other fields. Since the example refers to the post contents it should also pass the "content" field, besides key, id, and title. Otherwise, it is not possible to list the posts with their contents in the newly created Post component.
I recognize the example does not go far into showing the Post component. It just lists how the Blog component would use it, but still, it should use it by passing also the content field, as I mentioned above, besides the other fields (id, key as id, title).
This is a minor issue but still can improve the learning experience of many React beginners, or at least avoid beginners' confusion, especially if they try it on CodePen.