Skip to content

Update jsx-in-depth.md - #3921

Open
bukulele wants to merge 1 commit into
reactjs:mainfrom
bukulele:patch-1
Open

Update jsx-in-depth.md#3921
bukulele wants to merge 1 commit into
reactjs:mainfrom
bukulele:patch-1

Conversation

@bukulele

Copy link
Copy Markdown

The example in section "Functions as Children" works only with "0" index in props.children, because props.children is an array-like object, where the function is the value of the first property.

The example in section "Functions as Children" works only with "0" index in props.children, because props.children is an array-like object, where the function is the value of the first property.
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

Hi @bukulele!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot

Copy link
Copy Markdown
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@eps1lon

eps1lon commented Sep 27, 2021

Copy link
Copy Markdown
Member

The example in section "Functions as Children" works only with "0" index in props.children, because props.children is an array-like object, where the function is the value of the first property.

Not in this specific example. Are you maybe trying this example in preact?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants