fix(hydrateRoot): fix the hydration mismatch note for React 18 - #4668
Open
saurabhdaware wants to merge 1 commit into
Open
fix(hydrateRoot): fix the hydration mismatch note for React 18#4668saurabhdaware wants to merge 1 commit into
saurabhdaware wants to merge 1 commit into
Conversation
saurabhdaware
changed the title
Size ChangesDetails📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 This PR introduced no changes to the javascript bundle 🙌 |
saurabhdaware
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the breaking change mentioned in React 18 Upgrade Guide, hydration mismatch is now treated as an error instead of a warning and React doesn't try to patch text nodes.
I think the note on
hydrateRootwasn't updated for this change.Let me know if you need some rephrasing or if I misunderstood some part. Thanks!