Skip to content

In Testing Recipes, change to use root.unmount() and createRoot. - #4924

Open
yosipy wants to merge 3 commits into
reactjs:mainfrom
yosipy:react18-testing-recipes
Open

In Testing Recipes, change to use root.unmount() and createRoot.#4924
yosipy wants to merge 3 commits into
reactjs:mainfrom
yosipy:react18-testing-recipes

Conversation

@yosipy

@yosipy yosipy commented Aug 23, 2022

Copy link
Copy Markdown

fix: #4911

unmountComponentAtNode is used on Testing Recipes.
https://reactjs.org/docs/testing-recipes.html

However, unmountComponentAtNode(container) has been changed to root.unmount() in react 18.
It also shows to use createRoot.

I have updated the testing-recipes according to the upgrade-guide.
https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html

@facebook-github-bot

Copy link
Copy Markdown
Collaborator

Hi @yosipy!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@github-actions

github-actions Bot commented Aug 23, 2022

Copy link
Copy Markdown

Size Changes

Details

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@facebook-github-bot

Copy link
Copy Markdown
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In Testing Recipes, I want to change to use root.unmount() and createRoot.

2 participants