a11y: normalize TeamMember social link labels and mark icons aria-hid… - #8637
a11y: normalize TeamMember social link labels and mark icons aria-hid…#8637mdimamhosen wants to merge 1 commit into
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Description
Fixes #8552
On the Team page (
/community/team), the social links for GitHub and Personal Site previously used generic accessible labels ("GitHub Profile"and"Personal Site"). On a page listing dozens of members, screen reader users navigating links or rotor menus encountered identical, ambiguous links without knowing whose profile was referenced (WCAG 2.4.4 Link Purpose in Context).This PR:
aria-label={${name} on GitHub}.aria-label={${name}'s Personal Site}.aria-hidden="true"to decorative icons (IconTwitter,IconThreads,IconBsky,IconGitHub,IconLink) to ensure clean accessible names without conflicting nested SVG labels.Verification
yarn tscpassed (0 errors)yarn prettier:diffpassednext lintpassedDescription
Fixes #8552
On the Team page (
/community/team), the social links for GitHub and Personal Site previously used generic accessible labels ("GitHub Profile"and"Personal Site"). On a page listing dozens of members, screen reader users navigating links or rotor menus encountered identical, ambiguous links without knowing whose profile was referenced (WCAG 2.4.4 Link Purpose in Context).This PR:
aria-label={${name} on GitHub}.aria-label={${name}'s Personal Site}.aria-hidden="true"to decorative icons (IconTwitter,IconThreads,IconBsky,IconGitHub,IconLink) to ensure clean accessible names without conflicting nested SVG labels.Verification
yarn tscpassed (0 errors)yarn prettier:diffpassednext lintpassed