Fix hooks-faq.md, unnecessary dependency in example? - #3573
Conversation
|
Hi @uid11! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Deploy preview for reactjs ready! Built without sensitive environment variables with commit 29f83e4 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Is there any other action I need to take to move this pull request forward (merge or close)? |
If I understand correctly the intended API of the
useEventCallbackcustom hook, thedependenciesarray should contain all the dependencies of thefncallback itself (as in the standarduseCallbackhook).Thus, there is no need to additionally specify the
fncallback itself in the dependencies of this effect -- you need to update the link tofnin the ref only when something from thedependenciesarray changes.Moreover, now, due to the fact that
fnis specified in the effect dependencies, this effect is called after every render of theForm-- sincefn, as an arrow function literal, is created on every render.