Skip to content

Fix hooks-faq.md, unnecessary dependency in example? - #3573

Open
uid11 wants to merge 1 commit into
reactjs:mainfrom
uid11:patch-2
Open

Fix hooks-faq.md, unnecessary dependency in example?#3573
uid11 wants to merge 1 commit into
reactjs:mainfrom
uid11:patch-2

Conversation

@uid11

@uid11 uid11 commented Mar 11, 2021

Copy link
Copy Markdown

If I understand correctly the intended API of the useEventCallback custom hook, the dependencies array should contain all the dependencies of the fn callback itself (as in the standard useCallback hook).

Thus, there is no need to additionally specify the fn callback itself in the dependencies of this effect -- you need to update the link to fn in the ref only when something from the dependencies array changes.

Moreover, now, due to the fact that fn is specified in the effect dependencies, this effect is called after every render of the Form -- since fn, as an arrow function literal, is created on every render.

@facebook-github-bot

Copy link
Copy Markdown
Collaborator

Hi @uid11!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@reactjs-bot

Copy link
Copy Markdown

Deploy preview for reactjs ready!

Built without sensitive environment variables with commit 29f83e4

https://deploy-preview-3573--reactjs.netlify.app

@facebook-github-bot

Copy link
Copy Markdown
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@uid11

uid11 commented Sep 17, 2022

Copy link
Copy Markdown
Author

Is there any other action I need to take to move this pull request forward (merge or close)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants