Fix hooks-faq.md, unnecessary dependency in example? - #615
Closed
uid11 wants to merge 1 commit into
Closed
Conversation
|
Deploy preview for ru-reactjs ready! Built with commit 378e608 |
Contributor
Author
|
Видимо, предлагать правки в коде примеров нужно в основном репозитории документации, а не в переводе, поэтому закрыл в пользу reactjs/react.dev#3573. |
Contributor
Все верно, правки кода лучше предложить в основном репозитории документации. Как только их там примут, нам прилетит PR от бота на синхронизацию изменений. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I understand correctly the intended API of the
useEventCallbackcustom hook, thedependenciesarray should contain all the dependencies of thefncallback itself (as in the standarduseCallbackhook).Thus, there is no need to additionally specify the
fncallback itself in the dependencies of this effect -- you need to update the link tofnin the ref only when something from thedependenciesarray changes.Moreover, now, due to the fact that
fnis specified in the effect dependencies, this effect is called after every render of theForm-- sincefn, as an arrow function literal, is created on every render.