Skip to content

chore: release 10.56.0 - #638

Merged
sunnylqm merged 1 commit into
masterfrom
release/10.56.0
Sep 4, 2026
Merged

chore: release 10.56.0#638
sunnylqm merged 1 commit into
masterfrom
release/10.56.0

Conversation

@sunnylqm

@sunnylqm sunnylqm commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Release prep for 10.56.0 (the audit PRs #635 / #637).

  • ProGuard fix (release blocker found during verification). The audit's narrowed rules used void reload(java.lang.String) for ReactHostImpl, but RN's reload returns TaskInterface<Void>, so the rule matched nothing. In an R8-minified new-architecture build (RN 0.85, minifyEnabled true) the method was renamed and restartApp would reject RESTART_FAILED. The rule now uses a *** return type and also covers every ReactHost implementation.
  • Verification of the narrowed rules. Built the example app with minifyEnabled true and inspected the R8 output (dexdump + mapping): the three JNI result classes keep their no-arg constructor and every field, all 11 native methods keep their names, and every reflection target (getReactDelegate, ReactDelegate.reactHost, ReactHostImpl.useDevSupport / reactHostDelegate / reload, DefaultReactHostDelegate.jsBundleLoader, MainApplication.getReactHost, BuildConfig.IS_NEW_ARCHITECTURE_ENABLED, ReactContext.hasActiveReactInstance) is present. ReactNativeHost / ReactInstanceManager are empty shells in that app because the new-architecture template never instantiates them; those paths are old-arch only and guarded.
  • check-packlist.js accepts npm 12's object-shaped pack --json output.
  • Version bump to 10.56.0 in package.json and harmony/pushy/oh-package.json5.

🤖 Generated with Claude Code

https://claude.ai/code/session_0149oHt3QpNA3XNocSBVFNCh


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Bug Fixes

    • Fixed Android release builds so reload functionality remains available across supported runtime implementations.
    • Improved package validation compatibility with output formats used by newer npm versions.
  • Release Updates

    • Updated the package version to 10.56.0 across the project and Harmony package metadata.

- proguard: keep `reload(java.lang.String)` with a wildcard return type on
  ReactHostImpl and every ReactHost implementation. RN's reload returns
  TaskInterface<Void>, so the `void reload(...)` rule from the audit
  matched nothing and an R8-minified new-architecture build renamed the
  method, making restartApp reject RESTART_FAILED. Found by the minified
  release build the audit asked for; every other JNI class, native method
  and reflection target was verified present in the R8 output.
- check-packlist: accept npm 12's object-shaped `pack --json` output as
  well as the array older npm prints.
- bump package.json and oh-package.json5 to 10.56.0.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0149oHt3QpNA3XNocSBVFNCh
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: fe86c30d-c49c-49eb-8103-5cb4a0c6cdf0

📥 Commits

Reviewing files that changed from the base of the PR and between ec2ab50 and ef00356.

📒 Files selected for processing (4)
  • android/proguard.pro
  • harmony/pushy/oh-package.json5
  • package.json
  • scripts/check-packlist.js

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The PR updates Android ProGuard coverage for reload(String), supports npm 11 and npm 12 pack output formats, and bumps the root and Harmony package versions to 10.56.0.

Changes

Runtime and packaging updates

Layer / File(s) Summary
Preserve React Host reload methods
android/proguard.pro
ProGuard rules preserve reload(String) on ReactHostImpl and on ReactHost implementations with any return type.
Handle npm pack output formats
scripts/check-packlist.js
Pack-list parsing supports npm 11 array output and npm 12 object output.
Update package versions
package.json, harmony/pushy/oh-package.json5
Both package versions change from 10.55.1 to 10.56.0.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ef003

This release update preserves reflective Android reload behavior, supports current npm pack output formats, and aligns package versions at 10.56.0. No merge-blocking risk is identified.

Suggested reviewers: claude

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary objective: release preparation for version 10.56.0. It is concise and matches the version updates and supporting release changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/10.56.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sunnylqm
sunnylqm merged commit 583801a into master Sep 4, 2026
12 checks passed
@sunnylqm
sunnylqm deleted the release/10.56.0 branch September 4, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant