Skip to content

[CONTENT][SHORTCODES] Update version number template and improve download button - #149

Open
cbialorucki wants to merge 5 commits into
reactos:masterfrom
cbialorucki:fix-dl
Open

[CONTENT][SHORTCODES] Update version number template and improve download button#149
cbialorucki wants to merge 5 commits into
reactos:masterfrom
cbialorucki:fix-dl

Conversation

@cbialorucki

@cbialorucki cbialorucki commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Purpose

When we pushed the download page update, we never reached a consensus about how to change the wording above the download button or on the button itself. We also failed to update the reactos-version shortcode, so all version references on the site are stuck on 0.4.15.

Proposed changes

  • Remove reactos-download-version shortcode
  • Update reactos-version shortcode
  • Update download button header

@reactos-buildbot

Copy link
Copy Markdown
Collaborator

Thanks for your contribution!
I have built and deployed your changes to https://pr149.web-content.reactos.org and will also do that for your future changes.

Comment thread content/download.html Outdated
Comment thread content/download.html
Comment thread content/download.html Outdated
@binarymaster binarymaster added the enhancement New feature or request label Aug 29, 2026
Comment thread themes/reactos/layouts/shortcodes/reactos-version.html
cbialorucki and others added 3 commits August 29, 2026 07:22
Comment thread content/download.html

<div class="text-center">
<a id="bootcd" class="modalbtn" href="https://sourceforge.net/projects/reactos/files/latest/download"><div class="btn btn-primary">Download Release Image</div></a>
<h2>Discover our latest release</h2>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h2>Discover our latest release</h2>
<h2>Discover our latest release!</h2>

🤔

@oleg-dubinskiy oleg-dubinskiy Aug 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO an exclamation mark seems to be not necessary here.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just suggesting adding one, to add a happy tone to it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, from other side your argument sounds reasonable, so we can use it still.

@binarymaster binarymaster left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

Comment thread content/download.html

<div class="text-center">
<a id="bootcd" class="modalbtn" href="https://sourceforge.net/projects/reactos/files/latest/download"><div class="btn btn-primary">Download Release Image</div></a>
<h2>Discover our latest release</h2>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The headline font looks a bit too big, maybe use <h3> instead.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dunno; here it looks almost the same font as that of the button.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but in the "before" state the text looked a bit smaller, dunno why.

Before:
image

After:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants