Skip to content

Enable reactphp/async to work on PHP 5.3.6; ensure errors in correct order#1

Closed
matthew-andrews wants to merge 4 commits intoreactphp:masterfrom
matthew-andrews:patch-1
Closed

Enable reactphp/async to work on PHP 5.3.6; ensure errors in correct order#1
matthew-andrews wants to merge 4 commits intoreactphp:masterfrom
matthew-andrews:patch-1

Conversation

@matthew-andrews
Copy link

Enable the parallel function to work on PHP 5.3.6 (running the unit tests just emitted segfaults).

Also I noticed that the order of $errors would not necessarily match up with the order of parallel tasks so I fixed that too.

(I tried to use Travis to recreate the bug on 5.3.6, but it doesn't support that version 😕).

@matthew-andrews
Copy link
Author

Hi @cboden, sorry to bother you but have you had a chance to look at this? It'd be great to switch back on to the main library. Many thanks!

@cboden
Copy link
Member

cboden commented Aug 3, 2013

I'll take a look after my product launch on Monday.

@igorw
Copy link
Contributor

igorw commented Aug 5, 2013

Error handling is pretty much broken anyway because parallel aborts on the first error. It is highly recommended you stop using react/async and instead use promises. It is much more solid, composable, usable, and has an actual strategy for dealing with errors.

@igorw igorw closed this Aug 5, 2013
@igorw
Copy link
Contributor

igorw commented Aug 5, 2013

If you make a separate PR with only the changes for PHP 5.3.6, then I will merge it. But both old versions of PHP and react/async itself will not be maintained much longer. Use promises instead!

@matthew-andrews
Copy link
Author

Understood - will use promises.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants