Enable reactphp/async to work on PHP 5.3.6; ensure errors in correct order#1
Closed
matthew-andrews wants to merge 4 commits intoreactphp:masterfrom
Closed
Enable reactphp/async to work on PHP 5.3.6; ensure errors in correct order#1matthew-andrews wants to merge 4 commits intoreactphp:masterfrom
matthew-andrews wants to merge 4 commits intoreactphp:masterfrom
Conversation
Author
|
Hi @cboden, sorry to bother you but have you had a chance to look at this? It'd be great to switch back on to the main library. Many thanks! |
Member
|
I'll take a look after my product launch on Monday. |
Contributor
|
Error handling is pretty much broken anyway because |
Contributor
|
If you make a separate PR with only the changes for PHP 5.3.6, then I will merge it. But both old versions of PHP and react/async itself will not be maintained much longer. Use promises instead! |
Author
|
Understood - will use promises. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the
parallelfunction to work on PHP 5.3.6 (running the unit tests just emitted segfaults).Also I noticed that the order of
$errorswould not necessarily match up with the order of parallel tasks so I fixed that too.(I tried to use Travis to recreate the bug on 5.3.6, but it doesn't support that version 😕).