Skip to content

A11y metadata parsing for EPUB#135

Merged
mickael-menu merged 7 commits intoreadium:masterfrom
JayPanoz:a11y-metadata-parsing
May 15, 2020
Merged

A11y metadata parsing for EPUB#135
mickael-menu merged 7 commits intoreadium:masterfrom
JayPanoz:a11y-metadata-parsing

Conversation

@JayPanoz
Copy link
Copy Markdown
Contributor

@JayPanoz JayPanoz commented Apr 28, 2020

Re #94

The aim of this new doc is to provide guidance for parsing accessibility metadata in EPUB publications.

A review is warmly welcome.

Source diff | Rich diff

@llemeurfr
Copy link
Copy Markdown
Contributor

@danielweck was also speaking about dcterms:conformsTo, let's check with him.

@JayPanoz JayPanoz requested a review from danielweck April 28, 2020 18:11
Comment thread streamer/parser/a11y-metadata-parsing.md
Comment thread streamer/parser/a11y-metadata-parsing.md Outdated
Comment thread streamer/parser/a11y-metadata-parsing.md Outdated
Comment thread streamer/parser/a11y-metadata-parsing.md Outdated
Comment thread streamer/parser/a11y-metadata-parsing.md Outdated
Copy link
Copy Markdown
Member

@danielweck danielweck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

Comment thread streamer/parser/a11y-metadata-parsing.md Outdated
@mickael-menu
Copy link
Copy Markdown
Member

Is there still some work going on in this PR or we can merge it?

@JayPanoz
Copy link
Copy Markdown
Contributor Author

If I’m not mistaken, I think we’ve been waiting for a second review before merging it, as issues raised by Daniel initially have been resolved.

@mickael-menu mickael-menu merged commit 5f32529 into readium:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants