Shouldn't the publisher's defaults be enabled by default?

[mickael-menu]

The advanced-settings property is set to readium-advanced-on by default, according to the documentation, and this is reflected in the mobile apps. But shouldn't the publisher's default styles be enabled by default instead?

[JayPanoz]

Ah thanks for pointing this.

The doc is confusing indeed, as “default” means the default value that is expected for it to work when present on the root element (so it maps to the ReadiumCSS-config).

Then it’s up to implementers to pick whether they want it to be the default for all EPUB reflowable publications, or the ones who have only been customised via user prefs, etc.

But looking at this doc confused me as well moments ago, so I’ll try to clarify.

[mickael-menu]

Okay I see, so it's something to be fixed in the navigator then. Thanks!

[JayPanoz]

Yeah you can think of those flags as “boolean inline styles.” So

--USER__advancedSettings: "readium-advanced-on"

equals true. And other values equal false.

I can’t say they’re behaving like the boolean attributes in HTML because it’s not the case: their enabling/disabling indeed depends on the value. But it's the same idea.

I’ll have to recheck the entire docs to see if we’re event talking about real defaults for these flags though, in case there’s a conflict.