Skip to content

Fix vertically bouncing EPUB resources in iOS 16 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Fix vertically bouncing EPUB resources in iOS 16 #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ All notable changes to this project will be documented in this file. Take a look
* [#61](https://github.com/readium/swift-toolkit/issues/61) Fixed serving EPUB resources when the HREF contains an anchor or query parameters.
* Performance issue with EPUB fixed-layout when spreads are enabled.
* Disable scrolling in EPUB fixed-layout resources, in case the viewport is incorrectly set.
* Fix vertically bouncing EPUB resources in iOS 16.

#### Streamer

Expand Down
6 changes: 6 additions & 0 deletions Sources/Navigator/EPUB/EPUBReflowableSpreadView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,13 @@ final class EPUBReflowableSpreadView: EPUBSpreadView {

override func setupWebView() {
super.setupWebView()

scrollView.bounces = false
// Since iOS 16, the default value of alwaysBounceX seems to be true
// for web views.
scrollView.alwaysBounceVertical = false
scrollView.alwaysBounceHorizontal = false

scrollView.isPagingEnabled = !isScrollEnabled

webView.translatesAutoresizingMaskIntoConstraints = false
Expand Down