Skip to content

Conversation

@jspizziri
Copy link
Contributor

GCDWebServer 3.6.3 doesn't exist, the most recent version is 3.5.4.

See below:

@jspizziri jspizziri changed the title feat(readiumstreamer.podspec): fix dependency version for GCDWebServer fix(readiumstreamer.podspec): fix dependency version for GCDWebServer Mar 1, 2022
GCDWebServer 3.6.3 doesn't exist, the most recent version is 3.5.4.
@jspizziri jspizziri force-pushed the fix/streamer-podspec branch from 7d4090d to f28ee9d Compare March 1, 2022 16:03
@mickael-menu
Copy link
Member

@jspizziri Thanks for spotting this. However the right GCDWebServer lib to use is our fork at https://github.com/readium/GCDWebServer, whose latest version is 3.7.1. The Podspec doesn't seem to be correct as it references the official GCDWebServer.

@jspizziri
Copy link
Contributor Author

@mickael-menu, thanks for the response.

I'm assuming that package hasn't been published to Cocoapods officially either then? If so I'd like to add that to the list of packages for consideration of publishing formally. Until there's an official version this won't be able to be fixed for the same reason I mentioned here.

@mickael-menu
Copy link
Member

Yes, makes sense. Let's put your PR on hold for now.

@aferditamuriqi
Copy link
Member

We will not publish this dependency to CocoaPods, aside from it already existing and not being the same version as our fork, we would have to rename it in order to publish it. When you look into the official CocoaPods, nowadays there is a lot of duplications of pods and unmaintained pods overall, we would not want to contribute to that behavior, especially when we are not officially and fully supporting CocoaPods in our toolkit.

@mickael-menu
Copy link
Member

Closing for now, see #38 for the full context. We can reconsider if there's really no way to make it work without publishing it to CocoaPods.

@mickael-menu
Copy link
Member

After a second look, the issue remains to be fixed even if we don't publish the podspecs officially.

@mickael-menu mickael-menu reopened this Mar 20, 2022
@mickael-menu
Copy link
Member

It's a workaround until a proper fix, but you should add this to your app's Podfile to be able to use Readium's podspecs:

pod 'GCDWebServer', podspec: 'https://raw.githubusercontent.com/readium/GCDWebServer/3.6.3/GCDWebServer.podspec'

I will update the project README.

@mickael-menu
Copy link
Member

It seems that the Podspec doesn't allow to specify custom podspec files as dependencies. So this is the responsibility of the app to add in their Podfile:

pod 'GCDWebServer', podspec: 'https://raw.githubusercontent.com/readium/GCDWebServer/master/GCDWebServer.podspec'

This was already documented in the Podfile generated using make cocoapods with the Test App:

# Required for R2Streamer.
pod 'GCDWebServer', podspec: 'https://raw.githubusercontent.com/readium/GCDWebServer/3.6.3/GCDWebServer.podspec'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants