-
Notifications
You must be signed in to change notification settings - Fork 185
fix(readiumstreamer.podspec): fix dependency version for GCDWebServer #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
GCDWebServer 3.6.3 doesn't exist, the most recent version is 3.5.4.
7d4090d to
f28ee9d
Compare
|
@jspizziri Thanks for spotting this. However the right GCDWebServer lib to use is our fork at https://github.com/readium/GCDWebServer, whose latest version is 3.7.1. The Podspec doesn't seem to be correct as it references the official GCDWebServer. |
|
@mickael-menu, thanks for the response. I'm assuming that package hasn't been published to Cocoapods officially either then? If so I'd like to add that to the list of packages for consideration of publishing formally. Until there's an official version this won't be able to be fixed for the same reason I mentioned here. |
|
Yes, makes sense. Let's put your PR on hold for now. |
|
We will not publish this dependency to CocoaPods, aside from it already existing and not being the same version as our fork, we would have to rename it in order to publish it. When you look into the official CocoaPods, nowadays there is a lot of duplications of pods and unmaintained pods overall, we would not want to contribute to that behavior, especially when we are not officially and fully supporting CocoaPods in our toolkit. |
|
Closing for now, see #38 for the full context. We can reconsider if there's really no way to make it work without publishing it to CocoaPods. |
|
After a second look, the issue remains to be fixed even if we don't publish the podspecs officially. |
|
It's a workaround until a proper fix, but you should add this to your app's I will update the project README. |
|
It seems that the Podspec doesn't allow to specify custom podspec files as dependencies. So this is the responsibility of the app to add in their This was already documented in the swift-toolkit/TestApp/Integrations/CocoaPods/Podfile Lines 12 to 13 in fd8ad22
|
GCDWebServer 3.6.3 doesn't exist, the most recent version is 3.5.4.
See below: