Add an initializer parameter to LCP to pass a custom device id #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dewantawsif
changed the title
…lcp/device-id # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom device identifiers in the LCP service. The device ID can now be optionally provided during initialization, giving applications control over device identification while maintaining backward compatibility with auto-generated UUIDs.
Key Changes:
- Added optional
deviceIdparameter toLCPServiceinitializer - Refactored
DeviceServiceto accept custom device IDs while preserving fallback behavior - Updated documentation with usage guidelines for custom device identifiers
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/LCP/Services/DeviceService.swift | Converted id from computed property to stored property with initialization logic supporting custom, saved, or generated IDs |
| Sources/LCP/LCPService.swift | Added deviceId parameter to initializer and passed it through to DeviceService |
| CHANGELOG.md | Documented the new feature with contribution credit and usage recommendations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mickael-menu
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.