Add injectLicense to LCPService #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darktasevski
added a commit
to darktasevski/swift-toolkit
that referenced
this pull request
Oct 29, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the license injection logic and adds a new public API for injecting LCP license documents into publication packages. The main purpose is to allow users to manually inject licenses into downloaded publications without using the acquirePublication method.
Key Changes
- Extracted license injection logic into a reusable private method
injectLicenseAndGetFormat - Added a new public API
LCPService.injectLicenseDocument(_:in:)for manual license injection - Simplified the
acquirePublicationmethod by delegating to the extracted helper
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/LCP/Services/LicensesService.swift | Refactored acquirePublication to extract license injection logic into injectLicenseAndGetFormat; added injectLicenseDocument method |
| Sources/LCP/LCPService.swift | Added public injectLicenseDocument API that wraps the internal service method |
| CHANGELOG.md | Documented the new injectLicenseDocument API addition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
injectLicensetoLCPServiceto provide apps with more control on publication acquisition.