fix: resource requests with query parameters #67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitvishwakarma1819
changed the title
Member
|
Thanks for taking the time to contribute! I'll keep the other PR (#66) because we want to eventually remove the local HTTP server. Fixing this at the level of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Bug
#61
Some epubs access their resource by adding query parameter like (/xyzfilename.js?V=2.7.3). This was failing because the resources served were just file. So I added a fallback that if resources request fails to ResourceFailure then try getting the same resource again without query parameters and if this also doesn't work then go with the normal flow.
Also thanks to @vishalgupta7.
Thanks