Merged
Conversation
We happen to inject CSSSelectorGenerator in the Blob with a slight modification of replacing cssSelectorGenerator with a readium-prefixed version. This is not necessarily maintainable as this is hardcoded, and needs to be updated cautiously every time the dependency is updated. This also attemps to get rid of the error happening with `epub:type` attribute
chocolatkey
approved these changes
Jan 21, 2026
Contributor
Author
|
Yeah re. css selector, I came across this instance in services: At first sight it would be tempting to align it on |
No longer required as of 3.6.7, see https://github.com/fczbkk/css-selector-generator/blob/master/CHANGELOG.md#367-2024-03-15 – initially failed to catch the customized version was based on 3.6.4 and not the one listed in dependencies…
Contributor
Author
|
Well actually turns out I do not even need to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the vanilla test app and updates dependencies across packages.
This closes #117 through f10ef93 by scripting the modifications needed in CSS Selector Generator dependencies (Navigator > FrameBlobBuilder)
It adds all colon attributes e.g.
epub:typeinblacklistby default when outputting the custom script but maybe we want to scope this. I am not sure at the moment, despite testing the change – because it is tough to encounter edge cases from a limited amount of publications in Thorium Web.