Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

Feature/react error boundary#139

Merged
domharrington merged 8 commits intomasterfrom
feature/react-error-boundary
Sep 4, 2018
Merged

Feature/react error boundary#139
domharrington merged 8 commits intomasterfrom
feature/react-error-boundary

Conversation

@domharrington
Copy link
Copy Markdown
Member

@domharrington domharrington commented Aug 28, 2018

Example:
screen shot 2018-08-28 at 09 56 36

Example within readme:
Top level error boundary:
screen shot 2018-08-30 at 15 37 41

Endpoint error boundary:
screen shot 2018-08-30 at 15 38 12

I'm hoping that the only reason the stack traces are bad is due to React being in development.

In future i'd like for this to report to bugsnag or something, but I think this is okay for now.

Comment thread webpack.config.js
new webpack.HotModuleReplacementPlugin(),
],
devtool: 'eval-source-map',
devtool: 'cheap-module-source-map',
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this change for?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@domharrington domharrington merged commit ea959d9 into master Sep 4, 2018
@erunion erunion deleted the feature/react-error-boundary branch July 1, 2019 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants