This repository was archived by the owner on Nov 28, 2022. It is now read-only.
If we fail to render JSON, fallback to string rendering.#258
Merged
Conversation
domharrington
approved these changes
Aug 6, 2019
Member
domharrington
left a comment
domharrington
left a comment
There was a problem hiding this comment.
Tested locally and LGTM!
kanadgupta
approved these changes
Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds in some protections on our JSON rendering in response examples to prevent us from failing out on "Unexpected token" errors if we're attempt to render a string as JSON that isn't actually JSON. This kind of thing can happen if a response is documented as returning JSON, but instead has a simple string documented as an example.