This repository was archived by the owner on Nov 28, 2022. It is now read-only.
Merged
Conversation
mjcuva
changed the title
erunion
reviewed
Nov 14, 2019
Member
erunion
left a comment
erunion
left a comment
There was a problem hiding this comment.
LGTM but will let @rafegoldberg sign off before I merge.
rafegoldberg
approved these changes
Nov 15, 2019
Contributor
There was a problem hiding this comment.
So you just pulled these styles from #207 and added 'em to the bottom of the sheet, correct? this looks good to me; I might add a comment to that @media query so we know wtf it is doing in the future... But otherwise this looks good to go!
Member
|
I'll tag a release of this this afternoon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move changes to a new branch from master, since the other one became merge hell
Other pr: #207