Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

Feature/form styling 2#45

Merged
uppal101 merged 14 commits intomasterfrom
feature/form-styling-2
Oct 4, 2017
Merged

Feature/form styling 2#45
uppal101 merged 14 commits intomasterfrom
feature/form-styling-2

Conversation

@domharrington
Copy link
Copy Markdown
Member

No description provided.

@domharrington domharrington requested a review from uppal101 October 4, 2017 19:18
@domharrington
Copy link
Copy Markdown
Member Author

domharrington commented Oct 4, 2017

This currently gets the site to this state which is a pretty good start:

screen shot 2017-10-04 at 12 18 45

It still needs some work for arrays of objects and array types, but this needs a little more work.

I wanna get it this onto readme along with #40 so that people can start to review it.

"prettier": "^1.6.1",
"react-dom": "^15.6.1",
"react-test-renderer": "^15.6.1",
"raf": "^3.4.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this needed in the code?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up here: https://github.com/readmeio/api-explorer/pull/45/files#diff-249a8977b38cb9118e74a3cfb3008297R25 it's a requestAnimationFrame polyfill which is required in React 16

@uppal101 uppal101 merged commit 2a86dd0 into master Oct 4, 2017
@erunion erunion deleted the feature/form-styling-2 branch July 1, 2019 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants