Skip to content

fix(stripComments): properly pass in the micromark extensions#1335

Merged
maximilianfalco merged 2 commits intonextfrom
falco/strip-comments-mdxish-magic-block
Feb 11, 2026
Merged

fix(stripComments): properly pass in the micromark extensions#1335
maximilianfalco merged 2 commits intonextfrom
falco/strip-comments-mdxish-magic-block

Conversation

@maximilianfalco
Copy link
Contributor

PR App Fix RM-XYZ

🧰 Changes

We saw that the stripComments pipeline was incorrectly parsing magic blocks with the mdxish flag. Turns out, it was just because we were calling unified().data twice, which caused the second call to overwrite the first one, which in this case replaced the magic block extension with the mdx expression extension

Before After
Screenshot 2026-02-12 at 02 53 23 Screenshot 2026-02-12 at 02 54 20

🧬 QA & Testing

  1. Have a page contain this
[block:html]
{
  "html": "<div>Hello</div>"
}
[/block]
  1. View it as markdown
  2. The returned markdown should be correct

@maximilianfalco maximilianfalco marked this pull request as ready for review February 11, 2026 15:56
@maximilianfalco maximilianfalco merged commit 7ec9d46 into next Feb 11, 2026
11 checks passed
@maximilianfalco maximilianfalco deleted the falco/strip-comments-mdxish-magic-block branch February 11, 2026 20:41
rafegoldberg pushed a commit that referenced this pull request Feb 13, 2026
## Version 13.1.2
### 🛠 Fixes & Updates

* **magic blocks:** ensure newline characters processed as hard breaks ([#1329](#1329)) ([bb37d62](bb37d62))
* fix callout magic blocks when rendered directly below a list item ([#1331](#1331)) ([de2b82a](de2b82a))
* fix rendering content in table magic blocks ([#1318](#1318)) ([0ea1cfc](0ea1cfc))
* preserve recipe top level attributes in mdast ([#1324](#1324)) ([98f466b](98f466b))
* **stripComments:** properly pass in the micromark extensions ([#1335](#1335)) ([7ec9d46](7ec9d46))
* **mdxish:** properly terminate html blocks ([#1336](#1336)) ([d221861](d221861))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v13.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants