Merged
Conversation
Fix Github Action workflow
c++20 got stricter with it's requirements for aggregate initialization I guess, and these structs are POD so there should be no point in specifying any constructors at all
…stics() git_reference_target just returns a pointer to the git_reference's oid, it does not clone it so freeing the reference then wipes the oid
Bump @axosoft/nan and add ability to compile for c++20
necessary until node23 for building on newere versions of v8
define NOMINMAX on windows
git_errror_last will now return a "no-error" object instead of returning a null pointer
Bump libgit2 to 1.8.4, CI Updates
fix dependency graph
Dependency/Process Updates
fix electron dependencies again
Fix Invalid Import Assertion, Bump tar-fs
first parameter had it's name changed so it's no longer treated as an output parameter
Bump libgit2 to 1.9.1
llimllib
force-pushed
the
merge-libgit-191
branch
from
98d6e19 to
3560624
Compare
llimllib
commented
Nov 7, 2025
| .then(function() { | ||
| if (buildFlags.isGitRepo) { | ||
| var submodules = require(local("submodules")); | ||
| var applyPatches = require(local("patches/applyPatches")); |
Author
There was a problem hiding this comment.
This is the process that was necessary to support building zlib on mac, which is no longer needed with the libgit2 upgrade
erunion
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Maintenance note: I chose to bring in all the upstream history, with the intent to merge it without squashing so that git knows where we are relative to upstream. This ought to make it easier for me to merge upstream in the future
This PR will bring in a bunch of commits, but only actually merges the diff between https://github.com/nodegit/nodegit/tree/51650c7b4b7d65b35c80d4c62ead63072c54fbcc and https://github.com/nodegit/nodegit/tree/b9f3d16b61762e2ab24b9af10b821468ffe257b0 (view the diff here)