Skip to content

chore: bump tar to 7.5.2 to resolve gitto dependabot issue#19

Merged
julshotal merged 2 commits intomasterfrom
chore/bump-tar-dependabot
Nov 12, 2025
Merged

chore: bump tar to 7.5.2 to resolve gitto dependabot issue#19
julshotal merged 2 commits intomasterfrom
chore/bump-tar-dependabot

Conversation

@julshotal
Copy link

@julshotal julshotal commented Nov 11, 2025

🚥 Resolves ISSUE_ID

🧰 Changes

we've got a moderate dependabot issue popping up in gitto coming from here & the ai repo: https://github.com/readmeio/gitto/security/dependabot/110

this should fix it - but if this can't go into nodegit I can just push the AI repo one and then ignore the issue in gitto 🫡 figured it was worth a shot

🧬 QA & Testing

Provide as much information as you can on how to test what you've done.

@julshotal julshotal marked this pull request as ready for review November 11, 2025 23:53
package.json Outdated
@@ -48,6 +48,7 @@
"lodash": "^4.17.14",
"node-gyp": "^11.2.0",
Copy link
Member

@erunion erunion Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like node-gyp released v12 yesterday and they updated themselves to tar@7.5.2. v12 doesn't look like a breaking change for us so it might be worth trying to upgrade that instead? https://github.com/nodejs/node-gyp/releases/tag/v12.0.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool w/ this as-is tho

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give this a shot!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests definitely would have failed since they use node-gyp

@julshotal julshotal merged commit f4e5e34 into master Nov 12, 2025
8 checks passed
@julshotal julshotal mentioned this pull request Nov 12, 2025
@llimllib
Copy link

Blocked by nodejs/node-gyp#3239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants