feat: adding support for uploading and validating Postman collections #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
enhancement
erunion
commented
Nov 9, 2022
| debug(`attempting to oas-normalize ${file}`); | ||
| const oas = new OASNormalize(file, { enablePaths: true }); | ||
| return oas | ||
| .version() |
Member
Author
There was a problem hiding this comment.
I ended up bringing back .version() in oas-normalize@8.1.0 (readmeio/oas-normalize#227) but slightly changed the original API it had to give us some more information on the file it's been supplied.
erunion
changed the title
erunion
commented
Nov 9, 2022
erunion
commented
Nov 9, 2022
kanadgupta
approved these changes
Nov 9, 2022
Co-authored-by: Kanad Gupta <8854718+kanadgupta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
With v8 of oas-normalize we now have the ability to convert Postman collections to OpenAPI definitions thanks to postman-to-openapi. This work here integrates that work into our API definition upload and validation flow, which means that folks will now be able to upload Postman collections directly into their ReadMe projects.
😎 🛹