ci: verify Marketplace identity access#13
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR strengthens the repository’s release/publishing security posture by documenting the verified GitHub OIDC sub (subject) format used for Azure federated credentials and by adding an opt-in workflow step that verifies Marketplace publishing permissions without publishing anything. It also updates the “release readiness” verification script to enforce both the workflow and documentation requirements as part of the repo’s release contract.
Changes:
- Add an optional
workflow_dispatchboolean input (verify_marketplace_access) to the Marketplace identity workflow to run a non-publishing permission check viavsce verify-pat --azure-credential. - Document the repo’s current verified OIDC subject prefix (including org/repo numeric IDs) and provide a CLI-based way to confirm the
sub_claim_prefixbefore creating the Azure federated credential. - Lock both the new workflow input/permission-check behavior and the documented OIDC subject format into
scripts/verify-release-readiness.js.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/verify-release-readiness.js | Enforces presence of the new workflow input, vsce verify-pat usage, and the documented OIDC subject format as release-readiness requirements. |
| docs/RELEASING.md | Documents how to confirm the repo’s OIDC sub prefix and adds explicit instructions for optional Marketplace permission verification. |
| .github/workflows/marketplace-identity.yml | Adds an opt-in boolean input and a conditional step to verify Marketplace publishing permission via Azure credential (without publishing). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification