Merge remote-tracking branch 'origin/releases' into mc/merge/1.0_b0e18814#3014
Closed
Merge remote-tracking branch 'origin/releases' into mc/merge/1.0_b0e18814#3014
Conversation
* Add a Dockerfile to the repo This is done to facilitate CI and build reproducibility
* Enable -Wmissing-declarations and -Werror to ensure all global functions are defined with a proper declaration. JNI function not found problem can only be seen at run time, thus we need to do so. * Add static keyword for local functions. * Fix wrong JNI function declaration. * Remove useless functions. * TableView distinct should return void. * Rename JNI cpp files.
Contributor
Author
|
retest this please |
Contributor
Author
|
CI: retest this please |
Contributor
Author
|
CI: Please help me to retest this, thanks. |
Contributor
Author
|
CI:retest |
Contributor
Author
|
CI: retest |
Contributor
Author
|
merge #3016 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.