Merge remote-tracking branch 'origin/releases' into mc/merge/1.0_1f14e5e9#3016
Merged
Merge remote-tracking branch 'origin/releases' into mc/merge/1.0_1f14e5e9#3016
Conversation
* Add a Dockerfile to the repo This is done to facilitate CI and build reproducibility
* Enable -Wmissing-declarations and -Werror to ensure all global functions are defined with a proper declaration. JNI function not found problem can only be seen at run time, thus we need to do so. * Add static keyword for local functions. * Fix wrong JNI function declaration. * Remove useless functions. * TableView distinct should return void. * Rename JNI cpp files.
We have anecdotal evidence that multiple processes might be open for the same app. We have not been able to verify this, but the result matches the "IncompatibleLockFile" errors reported in #2459. This happens if the two processes have two versions of Realm (e.g. during app upgrades). This PR is based on our assumption that such an overlap is not intentional and only happens because one process is started before the previous was completely shut down. So this PR introduces an optimistic opening scheme where we retry for 3 second before crashing as before.
This was referenced Jun 16, 2016
beeender
force-pushed
the
mc/merge/1.0_1f14e5e9
branch
from
97d7110 to
0dd9122
Compare
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.